bodduv commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2721022989
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -51,6 +52,9 @@ public class ParquetMetricsRowGroupFilter {
private final Schema schema;
private final Expression expr;
+ // Expression using signed UUID comparator for backward compatibility with
files written before
+ // RFC-compliant UUID comparisons were introduced. Null if no UUID
predicates.
+ private final Expression signedUuidExpr;
public ParquetMetricsRowGroupFilter(Schema schema, Expression unbound) {
Review Comment:
`TestMetricsRowGroupFilter` is parametrized to test for both Parquet and
ORC. I have not found any other places `ParquetMetricsRowGroupFilter` is tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
