Copilot commented on code in PR #15118:
URL: https://github.com/apache/iceberg/pull/15118#discussion_r2721836244
##########
site/dev/common.sh:
##########
@@ -48,7 +48,8 @@ install_deps () {
echo " --> install deps"
# Use pip from venv to install or upgrade dependencies from the
'requirements.txt' file quietly
- "${VENV_DIR}/bin/pip3" -q install -r requirements.txt --upgrade
+ PIP="${PIP:-${VENV_DIR}/bin/pip3}"
+ ${PIP} -q install -r requirements.txt --upgrade
Review Comment:
The variable `${PIP}` should be quoted to prevent word splitting and glob
expansion. All other variable expansions in the codebase consistently use
double quotes (e.g., `"${VENV_DIR}/bin/python3"` on lines 26, 212, 221 of
common.sh, and in other scripts). This is a shell scripting best practice to
handle paths with spaces or special characters safely.
```suggestion
"${PIP}" -q install -r requirements.txt --upgrade
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
