kevinjqliu commented on PR #15118:
URL: https://github.com/apache/iceberg/pull/15118#issuecomment-3791125373
we hardcode `${VENV_DIR}/` at a bunch of places right now.
https://grep.app/search?f.path=site%2Fdev%2F&f.repo=apache%2Ficeberg&f.repo.pattern=iceberg&q=%7BVENV_DIR%7D
i think if we want to override this specific instance, we should override
all of them.
It might get confusing otherwise. For example, uv allows to create venv dir
with different names, while the script is hardcoded to `.venv`
https://github.com/apache/iceberg/blob/7493a158b38953a16672718bcb964d8b8b8ce34b/site/dev/common.sh#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
