zhangjun0x01 commented on a change in pull request #1765:
URL: https://github.com/apache/iceberg/pull/1765#discussion_r525885052
##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -129,11 +129,25 @@ public static void assertTableRows(String tablePath,
List<RowData> expected) thr
public static void assertTableRecords(Table table, List<Record> expected)
throws IOException {
table.refresh();
try (CloseableIterable<Record> iterable =
IcebergGenerics.read(table).build()) {
- Assert.assertEquals("Should produce the expected record",
- Sets.newHashSet(expected), Sets.newHashSet(iterable));
+ List<Record> iterList = Lists.newArrayList(iterable.iterator());
+ sortRecordList(iterList);
+ sortRecordList(expected);
+ Assert.assertEquals("Should produce the expected record", expected,
iterList);
}
}
+ private static void sortRecordList(List<Record> list) {
+ Collections.sort(list, (o1, o2) -> {
Review comment:
We can generate non-repetitive test data when writing test cases, but
there must be repeated data in the production environment. Will there be test
cases that pass but the production environment is incorrect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
