openinx commented on a change in pull request #1765:
URL: https://github.com/apache/iceberg/pull/1765#discussion_r526582765
##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -129,11 +129,25 @@ public static void assertTableRows(String tablePath,
List<RowData> expected) thr
public static void assertTableRecords(Table table, List<Record> expected)
throws IOException {
table.refresh();
try (CloseableIterable<Record> iterable =
IcebergGenerics.read(table).build()) {
- Assert.assertEquals("Should produce the expected record",
- Sets.newHashSet(expected), Sets.newHashSet(iterable));
+ List<Record> iterList = Lists.newArrayList(iterable.iterator());
+ sortRecordList(iterList);
+ sortRecordList(expected);
+ Assert.assertEquals("Should produce the expected record", expected,
iterList);
}
}
+ private static void sortRecordList(List<Record> list) {
+ Collections.sort(list, (o1, o2) -> {
Review comment:
In this SimpleDataUtil, all `Record` should have the same schema (`id`
and `data` column), so I think we could just compare those two fields
directly. Don't have to compare the hashCode.
About using `set` to compare lists, I'd prefer to compare sorted lists.
Because in future equality-delete test cases, we may delete the same row
several times to make sure that we've gurantteed the correct semantics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
