kevinjqliu commented on code in PR #2071:
URL: https://github.com/apache/iceberg-rust/pull/2071#discussion_r2733337844
##########
.github/workflows/ci.yml:
##########
@@ -169,9 +146,17 @@ jobs:
with:
key: ${{ matrix.test-suite.name }}
- - name: Test
+ - name: Start Docker containers
+ if: matrix.test-suite.name == 'default'
+ run: make docker-up
+
+ - name: Run tests
run: cargo test --no-fail-fast ${{ matrix.test-suite.args }}
+ - name: Stop Docker containers
+ if: always() && matrix.test-suite.name == 'default'
Review Comment:
ah `always()` here means "regardless of the previous step's outcome"
##########
Makefile:
##########
@@ -66,3 +67,13 @@ install-mdbook:
site: install-mdbook
cd website && mdbook serve
+
+# Docker targets for integration tests
+docker-up:
+ docker compose -f dev/docker-compose.yaml up -d --build --wait
+
+docker-down:
+ docker compose -f dev/docker-compose.yaml down -v --remove-orphans
Review Comment:
```suggestion
docker compose -f dev/docker-compose.yaml down -v --remove-orphans
--timeout 0
```
pyiceberg also uses `--timeout 0 ` to shutdown immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
