kevinjqliu commented on code in PR #2071:
URL: https://github.com/apache/iceberg-rust/pull/2071#discussion_r2734323996
##########
.github/workflows/ci.yml:
##########
@@ -169,9 +146,17 @@ jobs:
with:
key: ${{ matrix.test-suite.name }}
- - name: Test
+ - name: Start Docker containers
+ if: matrix.test-suite.name == 'default'
+ run: make docker-up
+
+ - name: Run tests
run: cargo test --no-fail-fast ${{ matrix.test-suite.args }}
+ - name: Stop Docker containers
+ if: always() && matrix.test-suite.name == 'default'
Review Comment:
yes we should! i didnt understand `always()` before, so this was just a
comment for other reviewers 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
