RussellSpitzer commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r2733444624
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##########
@@ -275,8 +275,14 @@ private ShreddedVariantWriter(
@Override
public void write(int repetitionLevel, VariantValue value) {
if (typedWriter.types().contains(value.type())) {
- typedWriter.write(repetitionLevel, value);
- writeNull(valueWriter, repetitionLevel, valueDefinitionLevel);
+ try {
+ typedWriter.write(repetitionLevel, value);
+ writeNull(valueWriter, repetitionLevel, valueDefinitionLevel);
+ } catch (IllegalArgumentException e) {
Review Comment:
Any way we can avoid having to try/fail here? Just wondering if it's just
for decimals can we do some decimal specific check or is this just much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
