RussellSpitzer commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r2733470255
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -134,6 +134,31 @@ private void ensureWriterInitialized() {
@Override
public void add(T value) {
+ if (model instanceof WriterLazyInitializable lazy) {
Review Comment:
This kind of feels to me like we should be making a subclass of
ParquetWriter which only takes lazy models rather than doing a special case
init here based on type matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
