ferhatelmas commented on code in PR #702:
URL: https://github.com/apache/iceberg-go/pull/702#discussion_r2737391851
##########
table/arrow_utils.go:
##########
@@ -1338,13 +1338,17 @@ func recordsToDataFiles(ctx context.Context,
rootLocation string, meta *Metadata
tasks := func(yield func(WriteTask) bool) {
defer stopCount()
+ fileCount := 0
for batch := range binPackRecords(args.itr, 20,
targetFileSize) {
Review Comment:
aside, 20 seems like the default used in multiple locations, might benefit
from putting it into a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
