zeroshade commented on code in PR #702:
URL: https://github.com/apache/iceberg-go/pull/702#discussion_r2737858860
##########
table/writer.go:
##########
@@ -33,15 +33,18 @@ import (
type WriteTask struct {
Uuid uuid.UUID
ID int
+ PartitionID int // Added: partition ID for file naming
+ FileCount int // Added: file counter within this task
Schema *iceberg.Schema
Batches []arrow.RecordBatch
SortOrderID int
}
func (w WriteTask) GenerateDataFileName(extension string) string {
// Mimics the behavior in the Java API:
- //
https://github.com/apache/iceberg/blob/a582968975dd30ff4917fbbe999f1be903efac02/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java#L92-L101
- return fmt.Sprintf("00000-%d-%s.%s", w.ID, w.Uuid, extension)
+ //
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
Review Comment:
that's a good point, i'll put it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
