jackye1995 opened a new pull request #1787:
URL: https://github.com/apache/iceberg/pull/1787
fix errorprone warnings in S3URIļ¼
```
/iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:60: warning:
[StringSplitter] String.split(String) has surprising behavior
String [] schemeSplit = location.split(SCHEME_DELIM);
^
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'List<String> schemeSplit =
Splitter.onPattern(SCHEME_DELIM).splitToList(location);'?
/iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:73: warning:
[StringSplitter] String.split(String) has surprising behavior
path = path.split(QUERY_DELIM)[0];
^
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'path =
Iterables.get(Splitter.onPattern(QUERY_DELIM).split(path), 0);'?
/iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:74: warning:
[StringSplitter] String.split(String) has surprising behavior
path = path.split(FRAGMENT_DELIM)[0];
^
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'path =
Iterables.get(Splitter.onPattern(FRAGMENT_DELIM).split(path), 0);'?
/iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:79: warning:
[MissingSummary] A summary fragment is required; consider using the value of
the @return block as a summary fragment instead.
* @return S3 bucket
^
(see
http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
Did you mean '*Returns s3 bucket.'?
/iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:86: warning:
[MissingSummary] A summary fragment is required; consider using the value of
the @return block as a summary fragment instead.
* @return S3 key
^
(see
http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
Did you mean '*Returns s3 key.'?
5 warnings
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
