RussellSpitzer commented on a change in pull request #1787:
URL: https://github.com/apache/iceberg/pull/1787#discussion_r527399103
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java
##########
@@ -70,19 +70,21 @@
// Strip query and fragment if they exist
String path = authoritySplit[1];
- path = path.split(QUERY_DELIM)[0];
- path = path.split(FRAGMENT_DELIM)[0];
+ path = path.split(QUERY_DELIM, -1)[0];
+ path = path.split(FRAGMENT_DELIM, -1)[0];
this.key = path;
}
/**
+ * S3 bucket name
Review comment:
The recommendation for these is to go with
```java
/**
* Return s3 bucket
*/
```
So you still have a one liner, but it's the summary only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
