gaborkaszab commented on PR #15192: URL: https://github.com/apache/iceberg/pull/15192#issuecomment-3836540510
Hey @adutra, Thanks for pulling me in. I took a look at the original test and I'm not 100% sure the original design is correct. When reading the metadata.json is a client-side responsibility, it could make sense, however for REST catalog when the metadata file is read on the server-side I'm not sure what we get with this test (other than testing our own test setup with REST catalog delegating to InMemoryCatalog and then returning an error to the client-side). Different server implementations can handle this differently. I'm wondering if we can simply turn this test off when it comes to testing Polaris, instead of trying to fix the test in one repo that makes something else fail in another project? Just for my understanding: this is open-source Apache Polaris testing, right? Another thing, but probably you got it figured out too: test caching is also turned on by default in TestRESTCatalog. That's also a sign that the test isn't really compliant with REST server implementations is that it required an override for the REST test suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
