adutra commented on PR #15192:
URL: https://github.com/apache/iceberg/pull/15192#issuecomment-3841138615
Hi @gaborkaszab, thanks for replying!
> I'm wondering if we can simply turn this test off when it comes to testing
Polaris, instead of trying to fix the test in one repo that makes something
else fail in another project?
That's an option, of course, but I'd prefer to improve the test itself if
possible.
> Just for my understanding: this is open-source Apache Polaris testing,
right?
Yes!
> the test isn't really compliant with REST server implementations is that
it required an override for the REST test suite.
Exactly, the test makes too many assumptions about the catalog impl imho.
Wdyt about promoting the override to top level? Basically, use FileIO to
delete the file AND invalidate the cache:
```java
table.io().deleteFile(metadataFileLocation);
catalog.invalidateTable(TBL);
assertThatThrownBy(() -> catalog.loadTable(TBL))
.isInstanceOf(NotFoundException.class)
.hasMessageContaining(metadataFileLocation);
```
Afaict this works for all catalog impls.
> the intent was to verify that the 404 returned by the server is translated
into a NotFoundException (and not a NoSuchTableException) on the client-side.
I think the intent is fine, provided that we factor out a potential cache
layer: "if a metadata.json is deleted by the client, assert that the catalog
detects it when loading a table, **iif the catalog is not caching**".
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
