jbewing commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2757057401
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
##########
@@ -555,6 +557,55 @@ public void testViewsReturnRecentResults() {
assertThat(actual2).hasSameSizeAs(expected2).isEqualTo(expected2);
}
+ @TestTemplate
+ public void testWriteDataFilesInTableSortOrder() {
+ File parent = temp.resolve(format.toString()).toFile();
+ File location = new File(parent, "test");
+ String targetLocation = locationWithBranch(location);
+
+ HadoopTables tables = new HadoopTables(CONF);
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ Table table = tables.create(SCHEMA, spec, location.toString());
Review Comment:
Can reduce. Full disclosure, this test is a copy-pasta derivative of our
friend `testUnpartitionedCreateWithTargetFileSizeViaTableProperties` which is
why they share a few similarities 😅
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
##########
@@ -555,6 +557,55 @@ public void testViewsReturnRecentResults() {
assertThat(actual2).hasSameSizeAs(expected2).isEqualTo(expected2);
}
+ @TestTemplate
+ public void testWriteDataFilesInTableSortOrder() {
+ File parent = temp.resolve(format.toString()).toFile();
+ File location = new File(parent, "test");
+ String targetLocation = locationWithBranch(location);
+
+ HadoopTables tables = new HadoopTables(CONF);
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ Table table = tables.create(SCHEMA, spec, location.toString());
Review Comment:
Can reduce. Full disclosure, this test is a copy-pasta derivative of our
friend `testUnpartitionedCreateWithTargetFileSizeViaTableProperties` which is
why they share a few similarities 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
