jbewing commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2757073023
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
##########
@@ -555,6 +557,55 @@ public void testViewsReturnRecentResults() {
assertThat(actual2).hasSameSizeAs(expected2).isEqualTo(expected2);
}
+ @TestTemplate
+ public void testWriteDataFilesInTableSortOrder() {
+ File parent = temp.resolve(format.toString()).toFile();
+ File location = new File(parent, "test");
+ String targetLocation = locationWithBranch(location);
+
+ HadoopTables tables = new HadoopTables(CONF);
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ Table table = tables.create(SCHEMA, spec, location.toString());
+
+ table.replaceSortOrder().asc("id").commit();
+
+ List<SimpleRecord> expected = Lists.newArrayListWithCapacity(4000);
+ for (int i = 0; i < 4000; i++) {
+ expected.add(new SimpleRecord(i, "a"));
+ }
+
+ Dataset<Row> df = spark.createDataFrame(expected, SimpleRecord.class);
+
+ df.select("id", "data")
+ .write()
+ .format("iceberg")
+ .option(SparkWriteOptions.WRITE_FORMAT, format.toString())
+ .mode(SaveMode.Append)
+ .save(location.toString());
+
+ createBranch(table);
Review Comment:
Yeah I copied this test template from the others in this class. I believe
they all/most have this and it looks to be leftover from
https://github.com/apache/iceberg/pull/6965. Happy to remove, but I was blindly
following the "template" that is in place here and going for consistency. So
TL;DR: no good reason that we're branching except that almost all the tests in
this class do it and I copied that template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
