Fokko commented on code in PR #2982:
URL: https://github.com/apache/iceberg-python/pull/2982#discussion_r2777974087
##########
pyiceberg/catalog/hive.py:
##########
@@ -729,7 +747,7 @@ def drop_namespace(self, namespace: str | Identifier) ->
None:
open_client.drop_database(database_name, deleteData=False,
cascade=False)
except InvalidOperationException as e:
raise NamespaceNotEmptyError(f"Database {database_name} is not
empty") from e
- except MetaException as e:
+ except (MetaException, NoSuchObjectException) as e:
Review Comment:
Nice catch!
##########
pyiceberg/catalog/__init__.py:
##########
@@ -733,9 +733,33 @@ def namespace_to_string(identifier: str | Identifier, err:
type[ValueError] | ty
return ".".join(segment.strip() for segment in tuple_identifier)
+ @abstractmethod
def supports_server_side_planning(self) -> bool:
"""Check if the catalog supports server-side scan planning."""
- return False
+
+ @abstractmethod
+ def supports_purge_table(self) -> bool:
+ """Check if the catalog supports purging tables."""
+
+ @abstractmethod
+ def supports_atomic_concurrent_updates(self) -> bool:
+ """Check if the catalog supports atomic concurrent updates."""
+
+ @abstractmethod
+ def supports_nested_namespaces(self) -> bool:
+ """Check if the catalog supports nested namespaces."""
+
+ @abstractmethod
+ def supports_schema_evolution(self) -> bool:
+ """Check if the catalog supports schema evolution."""
+
+ @abstractmethod
+ def supports_slash_in_identifier(self) -> bool:
+ """Check if the catalog supports slash in identifier."""
+
+ @abstractmethod
+ def supports_dot_in_identifier(self) -> bool:
+ """Check if the catalog supports dot in identifier."""
Review Comment:
These might be misleading. For example, some implementations of the REST
protocol might support this, while others not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
