rambleraptor commented on code in PR #2982:
URL: https://github.com/apache/iceberg-python/pull/2982#discussion_r2796104495
##########
pyiceberg/catalog/__init__.py:
##########
@@ -733,9 +733,33 @@ def namespace_to_string(identifier: str | Identifier, err:
type[ValueError] | ty
return ".".join(segment.strip() for segment in tuple_identifier)
+ @abstractmethod
def supports_server_side_planning(self) -> bool:
"""Check if the catalog supports server-side scan planning."""
- return False
+
+ @abstractmethod
+ def supports_purge_table(self) -> bool:
+ """Check if the catalog supports purging tables."""
+
+ @abstractmethod
+ def supports_atomic_concurrent_updates(self) -> bool:
+ """Check if the catalog supports atomic concurrent updates."""
+
+ @abstractmethod
+ def supports_nested_namespaces(self) -> bool:
+ """Check if the catalog supports nested namespaces."""
+
+ @abstractmethod
+ def supports_schema_evolution(self) -> bool:
+ """Check if the catalog supports schema evolution."""
+
+ @abstractmethod
+ def supports_slash_in_identifier(self) -> bool:
+ """Check if the catalog supports slash in identifier."""
+
+ @abstractmethod
+ def supports_dot_in_identifier(self) -> bool:
+ """Check if the catalog supports dot in identifier."""
Review Comment:
Yeah, agreed. I'm trying to match the Java functions. But, those functions
are implemented as part of CatalogTests, not Catalog. I've moved these methods
to `tests/conftest.py` to avoid polluting the catalog objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
