flyrain commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2785086639
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1249,6 +1249,41 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/sign/{provider}:
Review Comment:
Thanks a lot for working on this, @alaturqua.
I’m leaning toward option 3 since it covers more use cases without requiring
a mandatory `provider` in the path. The catalog implementation can still decide
how to behave based on whether provider is present or whether it can reliably
infer it from the input `uri`.
When the provider is explicitly provided, I think the catalog should honor
it. Making it optional also keeps things backward compatible while leaving room
for more complex scenarios, like supporting multiple storage providers.
```
3. Include the provider parameter in the request body
a. the client impl is responsible for generating it
b. must be optional for backwards compatibility
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
