singhpk234 commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2800259872
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4664,6 +4700,58 @@ components:
allOf:
- $ref: '#/components/schemas/Expression'
+ MultiValuedMap:
+ description: A map of string keys where each key can map to multiple
string values.
+ type: object
+ additionalProperties:
+ type: array
+ items:
+ type: string
+
+ RemoteSignRequest:
+ description: The request to be signed remotely.
+ type: object
+ required:
+ - region
+ - uri
+ - method
+ - headers
+ properties:
+ region:
+ type: string
+ uri:
+ type: string
+ method:
+ type: string
+ enum: ["PUT", "GET", "HEAD", "POST", "DELETE", "PATCH", "OPTIONS"]
+ headers:
+ $ref: '#/components/schemas/MultiValuedMap'
+ properties:
+ type: object
+ additionalProperties:
+ type: string
+ body:
+ type: string
+ description: Optional body of the request to send to the signing
API. This should only be populated
+ for requests where the body of the message contains content which
must be validated before a request is
+ signed, such as the S3 DeleteObjects call.
+ provider:
+ type: string
Review Comment:
>unless we go ahead an create enums for all major cloud providers?
thats what we had in mind, like let say s3 / azure / gcp and we can add
more in case to case basis, open string still leave room for interpretation in
catalog is what i think, but i can be convinced other wise :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
