blackmwk commented on code in PR #2131:
URL: https://github.com/apache/iceberg-rust/pull/2131#discussion_r2792263290
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -1351,20 +1351,6 @@ mod tests {
assert_eq!(catalog2.list_namespaces(None).await.unwrap(), vec![]);
}
- #[tokio::test]
- async fn test_list_namespaces_returns_multiple_namespaces() {
- let warehouse_loc = temp_path();
- let catalog = new_sql_catalog(warehouse_loc, Some("iceberg")).await;
- let namespace_ident_1 = NamespaceIdent::new("a".into());
- let namespace_ident_2 = NamespaceIdent::new("b".into());
- create_namespaces(&catalog, &vec![&namespace_ident_1,
&namespace_ident_2]).await;
-
- assert_eq!(
- to_set(catalog.list_namespaces(None).await.unwrap()),
- to_set(vec![namespace_ident_1, namespace_ident_2])
- );
- }
-
#[tokio::test]
async fn test_list_namespaces_returns_only_top_level_namespaces() {
Review Comment:
Sql catalog supports nested namespace, while others don't. These tests are
catalog specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
