blackmwk commented on code in PR #2131:
URL: https://github.com/apache/iceberg-rust/pull/2131#discussion_r2792628112
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -520,6 +545,15 @@ impl Catalog for HmsCatalog {
/// - Any network or communication error occurs with the database backend.
async fn drop_table(&self, table: &TableIdent) -> Result<()> {
let db_name = validate_namespace(table.namespace())?;
+ if !self.namespace_exists(table.namespace()).await? {
+ return Err(Error::new(
+ ErrorKind::DataInvalid,
Review Comment:
Fixed.
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -392,6 +411,12 @@ impl Catalog for HmsCatalog {
/// querying the database.
async fn list_tables(&self, namespace: &NamespaceIdent) ->
Result<Vec<TableIdent>> {
let name = validate_namespace(namespace)?;
+ if !self.namespace_exists(namespace).await? {
+ return Err(Error::new(
+ ErrorKind::DataInvalid,
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
