svalaskevicius commented on issue #15031: URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3892103440
an alternative option, that should work for both cases: would there be a way to inject/register a custom "make it an exiting threadpool" strategy? i.e. a function `ThreadPoolExecutor => ExecutorService` The default value would do the same thing: `return MoreExecutors.getExitingExecutorService(input)`. In flink's case, it would be possible to register a service that collects threadpools and has a manual shutdown() operation, this way giving the control and also not leaving shutdown hooks hanging about.. in my case I'd probably do the same (!!), as I know when it is safe to call the shutdown. it should work, if we make it a separate class - and register the custom static strategy _before_ the `ThreadPool` class is invoked. although I don't quite like the fact of the static-ness here... any thoughts? I'd be happy to try to come up with something suitable code-wise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
