wypoon commented on code in PR #15228:
URL: https://github.com/apache/iceberg/pull/15228#discussion_r2800646281


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -167,6 +167,10 @@ private static String convertToTypeString(Type type) {
       case FIXED:
       case BINARY:
         return "binary";
+      case VARIANT:

Review Comment:
   @ayushtkn @deniskuzZ IIUC, the variant type was added to Hive in 4.2.0 
([HIVE-29184](https://issues.apache.org/jira/browse/HIVE-29184)); can you 
confirm my understanding?
   Until we support Hive 4.2 (or later), we need this then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to