agaddis02 commented on PR #723: URL: https://github.com/apache/iceberg-go/pull/723#issuecomment-3903219511
@rockwotj, @zeroshade & @subkanthi, this pull request has been updated based on the comments left on the other PR: https://github.com/apache/iceberg-go/pull/710. Let me know if anything else needs to be added or changed, I believe this addresses the main points of concerns in terms of adding test, explicitly warning users that this can be dangerous, and attempting to curb that danger as much as possible by validating all of the possible items we can (with out scanning the file). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
