thomas-pfeiffer commented on PR #2993:
URL: https://github.com/apache/iceberg-python/pull/2993#issuecomment-3922545603
@kris-gaudel I have a few questions:
- Would it make sense to list the new configuration parameters somewhere in
`mkdocs/docs/configuration.md`, so that it shows up in the documentation as
well?
- Would it make sense to allow `PYICEBERG_MANIFEST__CACHE__SIZE` to be set
to `0` to effectively disable the cache?
- It's mentioned in
https://github.com/tkem/cachetools/issues/352#issuecomment-2927523908 that
`maxsize = 0` can be used to bypass the cache.
- This would make `PYICEBERG_MANIFEST__CACHE__ENABLED` obsolete, right?
- What's the added benefit of having a `_ManifestCacheManager` class?
- Wouldn't `_manifest_cache: LRUCache[str, ManifestFile] =
LRUCache(maxsize=int(environ.get("PYICEBERG_MANIFEST__CACHE__SIZE", 128)))` do
the trick as well? (obviously an oversimplified example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
