kris-gaudel commented on code in PR #2993:
URL: https://github.com/apache/iceberg-python/pull/2993#discussion_r2836875964
##########
pyiceberg/manifest.py:
##########
@@ -891,13 +893,79 @@ def __hash__(self) -> int:
return hash(self.manifest_path)
-# Global cache for ManifestFile objects, keyed by manifest_path.
-# This deduplicates ManifestFile objects across manifest lists, which commonly
-# share manifests after append operations.
-_manifest_cache: LRUCache[str, ManifestFile] = LRUCache(maxsize=128)
Review Comment:
@Fokko @thomas-pfeiffer
Thank you for the feedback, my intention with the cache manager was to
create some abstracted logic for interacting with the cache, since I thought
the two configuration parameters was the desired behaviour, I think these new
commits will address your concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
