Fokko commented on PR #3062: URL: https://github.com/apache/iceberg-python/pull/3062#issuecomment-3924863440
Hey @mrutunjay-kinagi Looking at the code: https://github.com/apache/iceberg/blame/d714576c7d53300e4b38d5ee27743dedbb153ace/core/src/main/java/org/apache/iceberg/TableMetadata.java#L360-L377 The first loop will ensure that the snapshot log entries are sorted when parsing the JSON. The second checks that the last snapshot entry is not ahead of the lastUpdatedMillis. If we want to add this to PyIceberg, I think a better place is to do this when constructing the Metadata: https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/metadata.py Similar to what Java/Rust are doing. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
