mrutunjay-kinagi commented on PR #3062: URL: https://github.com/apache/iceberg-python/pull/3062#issuecomment-3924977589
@Fokko Reposting cleanly (previous comment had shell formatting issues). Thanks, good suggestion. I pushed a follow-up commit that adds metadata-level timestamp validation in `pyiceberg/table/metadata.py` so we validate on metadata construction as well: - `snapshot-log` entries must remain sorted (with the same 1-minute skew tolerance used in Java) - `last-updated-ms` cannot be more than 1 minute behind the latest snapshot-log entry I also added parser-level tests in `tests/table/test_metadata.py` for both checks. I kept the existing `AddSnapshotUpdate` guard too, because that check depends on prior metadata state during update application (metadata parsing alone cannot fully recover that context). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
