Guosmilesmile commented on code in PR #15265:
URL: https://github.com/apache/iceberg/pull/15265#discussion_r2853523708
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -378,11 +381,55 @@ private static void assertEquals(
.isInstanceOf(byte[].class)
.isEqualTo(expected);
break;
+ case VARIANT:
+ assertThat(actual).as("Should expect a
Variant").isInstanceOf(Variant.class);
+ assertThat(expected)
+ .as("Should expect a Variant")
+ .isInstanceOf(org.apache.iceberg.variants.Variant.class);
Review Comment:
We need to use the fully qualified class name here because both Iceberg and
Flink have a class called `Variant`. The Flink one is already imported, so for
Iceberg we can only refer to it using its full name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
