pvary commented on code in PR #15265:
URL: https://github.com/apache/iceberg/pull/15265#discussion_r2853567574
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -378,11 +381,55 @@ private static void assertEquals(
.isInstanceOf(byte[].class)
.isEqualTo(expected);
break;
+ case VARIANT:
+ assertThat(actual).as("Should expect a
Variant").isInstanceOf(Variant.class);
+ assertThat(expected)
+ .as("Should expect a Variant")
+ .isInstanceOf(org.apache.iceberg.variants.Variant.class);
+ Variant flinkVariant = (Variant) actual;
+ org.apache.iceberg.variants.Variant icebergVariant =
+ (org.apache.iceberg.variants.Variant) expected;
+ compareVariants(icebergVariant, flinkVariant);
+ break;
default:
throw new IllegalArgumentException("Not a supported type: " + type);
}
}
+ private static void compareVariants(
+ org.apache.iceberg.variants.Variant icebergVariant, Variant
flinkVariant) {
+
+ org.apache.iceberg.variants.VariantValue icebergValue =
icebergVariant.value();
+ org.apache.iceberg.variants.VariantMetadata icebergMetadata =
icebergVariant.metadata();
Review Comment:
But we can import these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
