deniskuzZ commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2854264492
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -78,6 +78,7 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private boolean isAborted = false;
Review Comment:
@qlong you need to stage all table `PendingUpdates` — where would you keep
them?
The client uses the Transaction API to stage multiple table changes, and
`BaseTransaction` stores them in its `updates` list.
Adding prepareMetadata() to TableOps doesn’t provide any additional value
and isn't even linked to a Transaction in any way.
in order to link it you should override the `commitTransaction` copy&paste
plenty of things and do something like this
````
applyUpdates(underlyingOps);
underlyingOps. prepareMetadata(base, current);
````
but again `applyUpdates` & `updates` list are private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
