RussellSpitzer commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2854310646
##########
api/src/main/java/org/apache/iceberg/Transaction.java:
##########
@@ -183,4 +183,15 @@ default ManageSnapshots manageSnapshots() {
* @throws CommitFailedException If the updates cannot be committed due to
conflicts.
*/
void commitTransaction();
+
+ /**
+ * Rollback the transaction by cleaning up uncommitted changes.
Review Comment:
I'm not sure about the name Rollback here, since we already use "rollback"
to talk about returning whole table state.
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/ManageSnapshots.java#L62-L72
This on the other hand is not actually "rolling back" a change that happened
it is instead just erasing any files associated with the transaction. We also
probably need a protection that this can't be called if "commitTransaction" has
been called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
