mxm commented on code in PR #15433:
URL: https://github.com/apache/iceberg/pull/15433#discussion_r2878730306


##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/HashKeyGenerator.java:
##########
@@ -120,6 +120,9 @@ private KeySelector<RowData, Integer> getKeySelector(
         "Creating new KeySelector for table '{}' with distribution mode '{}'", 
tableName, mode);
     switch (mode) {
       case NONE:
+        return row -> 0;

Review Comment:
   Ideally, we would throw here and avoid this path to get executed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to