sqd commented on PR #15433: URL: https://github.com/apache/iceberg/pull/15433#issuecomment-3991481205
> I still see the flag in the above commit. We need to remove the flag and add a direct chained path, as an add-on to the existing topology. The flag is internal, not exposed through the public builder. I use a flag so I don't have to copy the code of DynamicIcebergSink into a very similar DynamicIcebergForwardSink or something. Instead we can reuse most of the logics. > side output Yes that's what I am doing (unless I am still missing something?). 1. [These lines](https://github.com/apache/iceberg/pull/15433/changes#diff-801a5d7fe4c27b9fb615ad487faf3cad0215058556aa8655c8f9ca72e644aeb9R420-R441) create and wire the normal path non-chained variant sink 2. [These lines](https://github.com/apache/iceberg/pull/15433/changes#diff-801a5d7fe4c27b9fb615ad487faf3cad0215058556aa8655c8f9ca72e644aeb9R451-R461) do the same for the new path chained variant sink Sorry about the CI failure. I know what's going on but a little swamped to fix them. I'll address them as soon as I can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
