danielcweeks commented on code in PR #15461:
URL: https://github.com/apache/iceberg/pull/15461#discussion_r2884490289
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -181,7 +232,8 @@ public static <T extends PartitionScanTask>
List<ScanTaskGroup<T>> planTaskGroup
List<T> groupingKeyTasks = entry.getValue();
Iterables.addAll(
taskGroups,
- toTaskGroupIterable(groupingKey, groupingKeyTasks, splitSize,
lookback, weightFunc));
+ toTaskGroupIterable(
+ groupingKey, groupingKeyTasks, splitSize, lookback, weightFunc,
fileIO));
Review Comment:
I'm not sure that it's helpful to have a separate FileIO per split.
Typically a scan task would be either a single split or a combination of
related splits. I could see a scenario where if you have multiple
paths/prefixes that are all mixed up across different locations, this could
result in a problem. However, I believe that would be better solved by better
grouping rather than complicating this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
