singhpk234 commented on code in PR #15461:
URL: https://github.com/apache/iceberg/pull/15461#discussion_r2884600175
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -181,7 +232,8 @@ public static <T extends PartitionScanTask>
List<ScanTaskGroup<T>> planTaskGroup
List<T> groupingKeyTasks = entry.getValue();
Iterables.addAll(
taskGroups,
- toTaskGroupIterable(groupingKey, groupingKeyTasks, splitSize,
lookback, weightFunc));
+ toTaskGroupIterable(
+ groupingKey, groupingKeyTasks, splitSize, lookback, weightFunc,
fileIO));
Review Comment:
I agree, and apologies for unclear message, I was questioning if we should
be doing it at per split level (like its done rn), my understanding was 1
ScanTaskGroup is one spark input partition ?
> I believe that would be better solved by better grouping rather than
complicating this more
Didn't fully get this are you supportive of this approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
