evindj commented on PR #553: URL: https://github.com/apache/iceberg-cpp/pull/553#issuecomment-4007501680
It is ok, I have been a bit busy lately so i could not make progress. > Let me know what you think, especially on the LiteralFromJson overload with schema input. I think this is generally fine, however, I wonder if there is a use care for binding only the Literal vs the current approach where binding happens later after deserialization. if the argument for doing so is that in the future we expect to push binding at deserialization time, then it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
