wgtmac commented on PR #553: URL: https://github.com/apache/iceberg-cpp/pull/553#issuecomment-4009049954
@evindj The main change I made here is that all deserialized predicates are unbound. This aligns with the Java impl where the schema is only used to aid in resolving literals without guessing it purely from the JSON text. Bound expression serde is a different topic (where bound reference serializes its field-id in the JSON text) and it is still under discussion so we don't need to handle them at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
