swapna267 commented on code in PR #15471:
URL: https://github.com/apache/iceberg/pull/15471#discussion_r2908677023
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableRecordGenerator.java:
##########
@@ -28,12 +33,44 @@
public abstract class DynamicTableRecordGenerator implements
DynamicRecordGenerator<RowData> {
private final RowType rowType;
+ private final Map<String, String> writeProps;
- public DynamicTableRecordGenerator(RowType rowType) {
+ public DynamicTableRecordGenerator(RowType rowType, Map<String, String>
writeProps) {
this.rowType = rowType;
+ this.writeProps = writeProps;
}
- protected RowType rowType() {
+ public RowType rowType() {
return rowType;
}
+
+ public Map<String, String> writeProps() {
+ return writeProps;
+ }
+
+ protected Map<String, Integer> getFieldPositionIndex() {
Review Comment:
Sure will rename. Added this method here to share across sub-classes.
Can add to a utility, but i think that would make it harder to see, for the
outside users providing implementations of DynamicTableRecordGenerator class.
Please let me know if there is any good place for such utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
