rdblue commented on code in PR #15583:
URL: https://github.com/apache/iceberg/pull/15583#discussion_r2920199143
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -66,7 +66,7 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
public HadoopFileIO() {}
public HadoopFileIO(Configuration hadoopConf) {
- this(new SerializableConfiguration(hadoopConf)::get);
+ this(new SerializableConfiguration(hadoopConf));
}
public HadoopFileIO(SerializableSupplier<Configuration> hadoopConf) {
Review Comment:
Should we deprecate this constructor and the `serializeConfWith` method?
That method will double-wrap the configuration if it is called. I like that
this should now be Kryo-compatible as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
