RussellSpitzer commented on code in PR #15583:
URL: https://github.com/apache/iceberg/pull/15583#discussion_r2926971929
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -66,7 +66,7 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
public HadoopFileIO() {}
public HadoopFileIO(Configuration hadoopConf) {
- this(new SerializableConfiguration(hadoopConf)::get);
+ this(new SerializableConfiguration(hadoopConf));
}
public HadoopFileIO(SerializableSupplier<Configuration> hadoopConf) {
Review Comment:
I think there is a question of whether that is important enough to keep this
method. As far as I can tell it's just for an optimization of not serializing
the Hadoop Conf?
It's only opt in (CONFIG_SERIALIZATION_DISABLED) is false by default and I'm
dubious it's even that beneficial now. Since we are going to be serializing
this all over the place in non-hadoop situations right? I would recommend we
just deprecate it then remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
