openinx commented on a change in pull request #1774:
URL: https://github.com/apache/iceberg/pull/1774#discussion_r530732751
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -271,8 +280,13 @@ public String toString() {
if (spec.fields().isEmpty()) {
return new Unpartitioned24Writer(spec, format, appenderFactory,
fileFactory, io.value(), targetFileSize);
} else {
- return new Partitioned24Writer(spec, format, appenderFactory,
fileFactory, io.value(),
- targetFileSize, writeSchema, dsSchema);
+ if (partitionedFanoutEnabled) {
Review comment:
nit: could simplify it as:
```java
if(spec.fields().isEmpty()){
} else if(partitionedFanoutEnabled){
} else {
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
