openinx commented on a change in pull request #1774:
URL: https://github.com/apache/iceberg/pull/1774#discussion_r530733127
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -307,4 +321,23 @@ public WriterCommitMessage commit() throws IOException {
return new TaskCommit(complete());
}
}
+
+ private static class PartitionedFanout24Writer extends
SparkPartitionedFanoutWriter
+ implements DataWriter<InternalRow> {
+
+ PartitionedFanout24Writer(PartitionSpec spec, FileFormat format,
+ SparkAppenderFactory appenderFactory,
+ OutputFileFactory fileFactory, FileIO fileIo, long targetFileSize,
+ Schema schema, StructType sparkSchema) {
Review comment:
nit: format those lines as:
```java
PartitionedFanout24Writer(PartitionSpec spec, FileFormat format,
SparkAppenderFactory appenderFactory,
OutputFileFactory fileFactory, FileIO fileIo,
long targetFileSize,
Schema schema, StructType sparkSchema) {
super(spec, format, appenderFactory, fileFactory, fileIo,
targetFileSize, schema, sparkSchema);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]