CTTY commented on code in PR #15530:
URL: https://github.com/apache/iceberg/pull/15530#discussion_r2933870850
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -176,7 +176,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// If we got an AWS exception we would usually handle, but find we
// succeeded on a retry that threw an exception, skip the exception.
- if (commitStatus != CommitStatus.SUCCESS && isAwsServiceException) {
+ if (commitStatus == CommitStatus.FAILURE && persistFailure instanceof
AwsServiceException) {
Review Comment:
Leaving the exception for L190 to throw makes sense, but imo it may not be
necessary. When commitStatus is UNKNOWN, an exception will be thrown anyway
My concern is that this could break existing exception handling logic in
downstream code, so I'm leaning toward keeping `commitStatus != SUCCESS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
