danielcweeks commented on code in PR #15652:
URL: https://github.com/apache/iceberg/pull/15652#discussion_r2940953435
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -253,16 +280,20 @@ protected FileAppender<ManifestEntry<DataFile>>
newAppender(
PartitionSpec spec, OutputFile file) {
Schema manifestSchema = V4Metadata.entrySchema(spec.partitionType());
try {
- return InternalData.write(FileFormat.AVRO, file)
- .schema(manifestSchema)
- .named("manifest_entry")
- .meta("schema", SchemaParser.toJson(spec.schema()))
- .meta("partition-spec", PartitionSpecParser.toJsonFields(spec))
- .meta("partition-spec-id", String.valueOf(spec.specId()))
- .meta("format-version", "4")
- .meta("content", "data")
- .overwrite()
- .build();
+ InternalData.WriteBuilder builder =
+ InternalData.write(FileFormat.AVRO, file)
Review Comment:
This is for the V4 writer. Did we want Parquet here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
