RussellSpitzer commented on code in PR #15652:
URL: https://github.com/apache/iceberg/pull/15652#discussion_r2941020005
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -625,6 +628,24 @@ protected RollingManifestWriter<DeleteFile>
newRollingDeleteManifestWriter(Parti
() -> newDeleteManifestWriter(spec), targetManifestSizeBytes);
}
+ private static Map<String, String> manifestWriterProperties(TableMetadata
metadata) {
+ ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
+
+ String codec =
+ metadata.property(
+ TableProperties.AVRO_COMPRESSION,
TableProperties.AVRO_COMPRESSION_DEFAULT);
Review Comment:
We don't have Parquet manifests (yet) in this PR. When we add that I think
we should respect either the Avro or Parquet property depending on the manifest
output format.
My broader question is wether we should have a manifest specific compression
property but as I mentioned in the discussion, I don't think it really makes
sense to have a user use one compression type for data files and a different
for manifests ... but maybe it does? it would be easy enough for us to add
later if the use case comes up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
