RussellSpitzer commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2957445843
##########
core/src/test/java/org/apache/iceberg/util/TestSortOrderUtil.java:
##########
@@ -287,4 +287,68 @@ public void
testSortOrderClusteringWithRedundantPartitionFieldsMissing() {
.as("Should add spec fields as prefix")
.isEqualTo(expected);
}
+
+ @Test
+ public void testFindSortOrderForTable() {
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ SortOrder order = SortOrder.builderFor(SCHEMA).withOrderId(1).asc("id",
NULLS_LAST).build();
+ TestTables.TestTable table = TestTables.create(tableDir, "test", SCHEMA,
spec, order, 2);
+
+ SortOrder tableSortOrder = table.sortOrder();
+
+ SortOrder actualOrder = SortOrderUtil.maybeFindTableSortOrder(table,
tableSortOrder);
+
+ assertThat(actualOrder).as("Should find current table sort
order").isEqualTo(table.sortOrder());
+ }
+
+ @Test
+ public void testFindSortOrderForTableWithoutFieldId() {
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ SortOrder order = SortOrder.builderFor(SCHEMA).withOrderId(1).asc("id",
NULLS_LAST).build();
+ TestTables.TestTable table = TestTables.create(tableDir, "test", SCHEMA,
spec, order, 2);
+
+ SortOrder userSuppliedOrder =
+ SortOrder.builderFor(table.schema()).asc("id", NULLS_LAST).build();
+
+ SortOrder actualOrder = SortOrderUtil.maybeFindTableSortOrder(table,
userSuppliedOrder);
+
+ assertThat(actualOrder).as("Should find current table sort
order").isEqualTo(table.sortOrder());
+ }
+
+ @Test
+ public void testFindSortOrderForTableThatIsNotCurrentOrder() {
+ PartitionSpec spec = PartitionSpec.unpartitioned();
+ SortOrder order = SortOrder.builderFor(SCHEMA).withOrderId(1).asc("id",
NULLS_LAST).build();
+ TestTables.TestTable table = TestTables.create(tableDir, "test", SCHEMA,
spec, order, 2);
+
+ table.replaceSortOrder().asc("data").desc("ts").commit();
+
+ SortOrder userSuppliedOrder =
+ SortOrder.builderFor(table.schema()).asc("id", NULLS_LAST).build();
+
+ SortOrder actualOrder = SortOrderUtil.maybeFindTableSortOrder(table,
userSuppliedOrder);
+
+ assertThat(actualOrder)
+ .as("Should find first sorted table sort order")
+ .isEqualTo(table.sortOrders().get(1));
+ }
+
+ @Test
+ public void testReturnsEmptyForFindingNonMatchingSortOrder() {
Review Comment:
nit: testReturnsUnsortedForMissingSortOrder
Since it isn't empty, just unsorted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
