mxm commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2966340425
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -171,6 +172,26 @@ public int outputSpecId() {
return outputSpecId;
}
+ public int outputSortOrderId(SparkWriteRequirements writeRequirements) {
+ String explicitId =
+
confParser.stringConf().option(SparkWriteOptions.OUTPUT_SORT_ORDER_ID).parseOptional();
+
+ if (explicitId != null) {
+ int id = Integer.parseInt(explicitId);
+ Preconditions.checkArgument(
+ table.sortOrders().containsKey(id),
+ "Cannot use output sort order id %s because the table does not
contain a sort order with that id",
+ id);
+ return id;
+ }
+
+ if (writeRequirements.hasOrdering()) {
+ return table.sortOrder().orderId();
Review Comment:
Thanks for elaborating on the approach. It would be good to be as explicit
as possible.
>else, if spark has a sort order set, it must correspond to the iceberg sort
order
I'm missing that part. We are making the assumption Iceberg's SortOrder
matches Spark's SortOrder and just blindly returning the current table order.
Would it make sense to build a Spark SortOrder from the Iceberg SortOrder and
verify whether it matches the one from WriteRequirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
